jenkins-bot has submitted this change and it was merged.
Change subject: Convert field to local variable in ReadingListDetailView class
......................................................................
Convert field to local variable in ReadingListDetailView class
This patch converts a field which is only used in one method in the
ReadingListDetailView class to a local variable, to improve performance and
code cleanliness.
Change-Id: Ia54425f30baa97587beb93e3be44d89a9f606134
---
M app/src/main/java/org/wikipedia/readinglist/ReadingListDetailView.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/app/src/main/java/org/wikipedia/readinglist/ReadingListDetailView.java
b/app/src/main/java/org/wikipedia/readinglist/ReadingListDetailView.java
index 3cf9237..5d52df6 100644
--- a/app/src/main/java/org/wikipedia/readinglist/ReadingListDetailView.java
+++ b/app/src/main/java/org/wikipedia/readinglist/ReadingListDetailView.java
@@ -53,7 +53,6 @@
private ReadingListPageItemAdapter adapter = new
ReadingListPageItemAdapter();
private EditButtonClickListener editButtonListener = new
EditButtonClickListener();
- private ItemTouchHelper itemTouchHelper;
private Bitmap deleteIcon = getDeleteBitmap();
public interface ReadingListItemActionListener {
@@ -129,7 +128,7 @@
setLayoutParams(new
LinearLayoutCompat.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT,
ViewGroup.LayoutParams.WRAP_CONTENT));
ItemTouchHelper.Callback touchCallback = new
ReadingListItemTouchHelperCallback();
- itemTouchHelper = new ItemTouchHelper(touchCallback);
+ ItemTouchHelper itemTouchHelper = new ItemTouchHelper(touchCallback);
itemTouchHelper.attachToRecyclerView(contentsListView);
}
--
To view, visit https://gerrit.wikimedia.org/r/300715
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia54425f30baa97587beb93e3be44d89a9f606134
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
