jenkins-bot has submitted this change and it was merged.
Change subject: No default values for final status message properties
......................................................................
No default values for final status message properties
We want to be able to have a sparse update message that doesn't
clobber existing data
Bug: T137590
Change-Id: Ia023d97ea420e5c9b13ee4700f24b85182ca4207
---
M CrmLink/Messages/DonationInterfaceFinalStatus.php
1 file changed, 13 insertions(+), 13 deletions(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CrmLink/Messages/DonationInterfaceFinalStatus.php
b/CrmLink/Messages/DonationInterfaceFinalStatus.php
index e63aa14..dc635b4 100644
--- a/CrmLink/Messages/DonationInterfaceFinalStatus.php
+++ b/CrmLink/Messages/DonationInterfaceFinalStatus.php
@@ -6,17 +6,17 @@
* Message sent once frontend donation processing is completed
*/
class DonationInterfaceFinalStatus extends KeyedOpaqueStorableObject {
- public $amount = '';
- public $contribution_tracking_id = '';
- public $country = '';
- public $currency_code = '';
- public $date = '';
- public $gateway = '';
- public $gateway_txn_id = '';
- public $order_id = '';
- public $payment_method = '';
- public $payments_final_status = '';
- public $payment_submethod = '';
- public $server = '';
- public $validation_action = '';
+ public $amount;
+ public $contribution_tracking_id;
+ public $country;
+ public $currency_code;
+ public $date;
+ public $gateway;
+ public $gateway_txn_id;
+ public $order_id;
+ public $payment_method;
+ public $payments_final_status;
+ public $payment_submethod;
+ public $server;
+ public $validation_action;
}
--
To view, visit https://gerrit.wikimedia.org/r/299819
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia023d97ea420e5c9b13ee4700f24b85182ca4207
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
