jenkins-bot has submitted this change and it was merged.
Change subject: Improve output of betafeatures script
......................................................................
Improve output of betafeatures script
Change-Id: Ia85ac6ea4f05ff273227c5a7e5ce677490630af1
---
M src/betafeatures/counts.php
1 file changed, 4 insertions(+), 6 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/betafeatures/counts.php b/src/betafeatures/counts.php
index 1c86b5a..76b06b2 100755
--- a/src/betafeatures/counts.php
+++ b/src/betafeatures/counts.php
@@ -53,7 +53,7 @@
$sql = "SELECT * FROM $dbname.betafeatures_user_counts";
$queryResult = $pdo->query( $sql );
if( $queryResult === false ) {
- Output::timestampedMessage( "beta features DB query 1 failed
for $dbname, Skipping!! " );
+ Output::timestampedMessage( "SELECT 1 failed for $dbname,
Skipping!! " );
} else {
foreach( $queryResult as $row ) {
$feature = $row['feature'];
@@ -70,7 +70,7 @@
$sql .= " WHERE up_property = '$feature' AND up_value = '1'";
$queryResult = $pdo->query( $sql );
if( $queryResult === false ) {
- Output::timestampedMessage( "beta features DB query 2
failed for $dbname for feature $feature, Skipping!!" );
+ Output::timestampedMessage( "INSERT INTO FAILED for
$dbname for feature $feature, Skipping!!" );
}
}
}
@@ -86,11 +86,9 @@
$sql .= " GROUP BY feature";
$queryResult = $pdo->query( $sql );
if( $queryResult === false ) {
- Output::timestampedMessage( "beta features select from
staging.wmde_analytics_betafeature_users failed!!" );
+ Output::timestampedMessage( "SELECT FROM
staging.wmde_analytics_betafeature_users FAILED!!" );
} else {
foreach( $queryResult as $row ) {
- $feature = $row['feature'];
- $count = $row['count'];
- WikimediaGraphite::sendNow(
'daily.betafeatures.global_user_counts.totals.' . $featureName, $value );
+ WikimediaGraphite::sendNow(
'daily.betafeatures.global_user_counts.totals.' . $row['feature'],
$row['count'] );
}
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/300907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia85ac6ea4f05ff273227c5a7e5ce677490630af1
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wmde/scripts
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
