Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/300911
Change subject: graphite: Set xFilesFactor to 0 for sum/count.
......................................................................
graphite: Set xFilesFactor to 0 for sum/count.
Carbon uses xFilesFactor to decide whether to aggregate Whisper
data from one window to another (e.g. summarise the last 7days in
the 30d+ range).
Follows-up 2e1a45c0, which lowered it from 0.1 to 0.01 for most
properties. But, it changed 'count' and 'sum' from 0 to 0.01.
Per the original dc005cb9 settings, set these back to 0. Sum and
count are expected to be more-or-less reliable totals. Otherwise
even high numbers may disappear if they were reported at slow
intervals.
Change-Id: I3e3db984c19334b84d239429deaf6aee1d223cac
---
M modules/role/manifests/graphite/base.pp
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/11/300911/1
diff --git a/modules/role/manifests/graphite/base.pp
b/modules/role/manifests/graphite/base.pp
index 17e6d74..65a3077 100644
--- a/modules/role/manifests/graphite/base.pp
+++ b/modules/role/manifests/graphite/base.pp
@@ -66,12 +66,12 @@
},
'count' => {
pattern => '\.count$',
- xFilesFactor => 0.01,
+ xFilesFactor => 0,
aggregationMethod => 'sum',
},
'sum' => {
pattern => '\.sum$',
- xFilesFactor => 0.01,
+ xFilesFactor => 0,
aggregationMethod => 'sum',
},
# statsite extended counters
--
To view, visit https://gerrit.wikimedia.org/r/300911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e3db984c19334b84d239429deaf6aee1d223cac
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
