BBlack has submitted this change and it was merged.
Change subject: cache_misc: fix Authz->pass
......................................................................
cache_misc: fix Authz->pass
Default builtin VCL would do this, but our common core VCL doesn't
invoke the default. That's fine on other clusters, but not here
on cache_misc...
Bug: T141430
Change-Id: I72a5ca8b64a73233ee5c116658777b23dee45f9c
---
M templates/varnish/misc-common.inc.vcl.erb
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
BBlack: Verified; Looks good to me, approved
diff --git a/templates/varnish/misc-common.inc.vcl.erb
b/templates/varnish/misc-common.inc.vcl.erb
index 74ccdce..6a74cba 100644
--- a/templates/varnish/misc-common.inc.vcl.erb
+++ b/templates/varnish/misc-common.inc.vcl.erb
@@ -17,4 +17,11 @@
// We only deal with GET and HEAD
return (pass);
}
+
+ // Note default builtin VCL would pass on req.http.Cookie here too, but
+ // that would pass virtually all content, as junk cookies are common
+ // (including our own, for these purposes)
+ if (req.http.Authorization) {
+ return (pass);
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/301360
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72a5ca8b64a73233ee5c116658777b23dee45f9c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
