Filippo Giunchedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/301785
Change subject: prometheus: fix arguments for mysqld_exporter
......................................................................
prometheus: fix arguments for mysqld_exporter
Results in runtime error:
interning empty string at
/etc/puppet/modules/prometheus/manifests/mysqld_exporter.pp:40
Change-Id: I165a725f02e6e8b2c999d4b81e0538ef0411c3f4
---
M modules/prometheus/manifests/mysqld_exporter.pp
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/85/301785/1
diff --git a/modules/prometheus/manifests/mysqld_exporter.pp
b/modules/prometheus/manifests/mysqld_exporter.pp
index f0da947..9641bf8 100644
--- a/modules/prometheus/manifests/mysqld_exporter.pp
+++ b/modules/prometheus/manifests/mysqld_exporter.pp
@@ -37,13 +37,13 @@
notify => Service['prometheus-mysqld-exporter'],
}
- if defined($arguments) {
+ if $arguments != '' {
file { '/etc/default/prometheus-mysqld-exporter':
ensure => present,
mode => '0444',
owner => 'root',
group => 'root',
- content => "ARGS='${arguments}'",
+ content => "ARGS=${arguments}",
notify => Service['prometheus-mysqld-exporter'],
}
}
--
To view, visit https://gerrit.wikimedia.org/r/301785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I165a725f02e6e8b2c999d4b81e0538ef0411c3f4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
