ArielGlenn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/302279
Change subject: include standard and base::firewall in manifest common to
snapshots
......................................................................
include standard and base::firewall in manifest common to snapshots
this gets it out of the node declaration in site.pp
Change-Id: I41c97c18fee22ea08443429ec2e7e50ff693fd04
---
M manifests/site.pp
M modules/role/manifests/snapshot/common.pp
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/79/302279/1
diff --git a/manifests/site.pp b/manifests/site.pp
index 2821752..3d31de4 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -2794,8 +2794,6 @@
# modules/scap/files/dsh/group/mediawiki-installation,
# and modules/snapshot/files/deployment/dump_targets
role snapshot::dumper, snapshot::monitor, snapshot::cronrunner
- include standard
- include base::firewall
}
# codfw poolcounters
diff --git a/modules/role/manifests/snapshot/common.pp
b/modules/role/manifests/snapshot/common.pp
index c527e81..fe0adeb 100644
--- a/modules/role/manifests/snapshot/common.pp
+++ b/modules/role/manifests/snapshot/common.pp
@@ -1,5 +1,6 @@
class role::snapshot::common {
include ::dataset::user
+ include standard
include base::firewall
# mw packages and dependencies, dataset server nfs mount,
--
To view, visit https://gerrit.wikimedia.org/r/302279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41c97c18fee22ea08443429ec2e7e50ff693fd04
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: ArielGlenn <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
