jenkins-bot has submitted this change and it was merged.
Change subject: Regression: remove the language overlay header chrome
......................................................................
Regression: remove the language overlay header chrome
Per Nirzar the language overlay header should not have a chrome.
The regression was introduced in 13eef197cd88dad7b8bb5065cef37c87d4d3b72c.
Bug: T140653
Change-Id: I5d28564541fefb18c86abc367905521940d00e5b
---
M resources/mobile.languages.structured/LanguageOverlay.js
M resources/mobile.overlays/Overlay.hogan
M resources/mobile.overlays/Overlay.js
3 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.languages.structured/LanguageOverlay.js
b/resources/mobile.languages.structured/LanguageOverlay.js
index 546ce82..6681771 100644
--- a/resources/mobile.languages.structured/LanguageOverlay.js
+++ b/resources/mobile.languages.structured/LanguageOverlay.js
@@ -40,7 +40,8 @@
inputPlaceholder: mw.msg(
'mobile-frontend-languages-structured-overlay-search-input-placeholder' ),
// we can't rely on CSS only to uppercase the headings.
See
https://stackoverflow.com/questions/3777443/css-text-transform-not-working-properly-for-turkish-characters
allLanguagesHeader: mw.msg(
'mobile-frontend-languages-structured-overlay-all-languages-header'
).toLocaleUpperCase(),
- suggestedLanguagesHeader: mw.msg(
'mobile-frontend-languages-structured-overlay-suggested-languages-header'
).toLocaleUpperCase()
+ suggestedLanguagesHeader: mw.msg(
'mobile-frontend-languages-structured-overlay-suggested-languages-header'
).toLocaleUpperCase(),
+ headerChrome: false
} ),
/** @inheritdoc */
templatePartials: $.extend( {},
Overlay.prototype.templatePartials, {
diff --git a/resources/mobile.overlays/Overlay.hogan
b/resources/mobile.overlays/Overlay.hogan
index 245cd01..5ed256a 100644
--- a/resources/mobile.overlays/Overlay.hogan
+++ b/resources/mobile.overlays/Overlay.hogan
@@ -1,4 +1,4 @@
-<div class="overlay-header-container header-container
header-chrome{{#fixedHeader}} position-fixed{{/fixedHeader}}">
+<div class="overlay-header-container header-container{{#headerChrome}}
header-chrome{{/headerChrome}}{{#fixedHeader}} position-fixed{{/fixedHeader}}">
<div class="overlay-header header">
{{>header}}
</div>
diff --git a/resources/mobile.overlays/Overlay.js
b/resources/mobile.overlays/Overlay.js
index 22654a1..c0d30a0 100644
--- a/resources/mobile.overlays/Overlay.js
+++ b/resources/mobile.overlays/Overlay.js
@@ -65,6 +65,7 @@
* @cfg {String} defaults.backButton HTML of the back button.
* @cfg {String} defaults.headerButtonsListClassName A comma
separated string of class
* names of the wrapper of the header buttons.
+ * @cfg {Boolean} defaults.headerChrome Whether the header has
chrome.
* @cfg {Boolean} defaults.fixedHeader Whether the header is
fixed.
* @cfg {String} defaults.spinner HTML of the spinner icon.
* @cfg {Object} [defaults.footerAnchor] options for an
optional Anchor that can appear in the footer
@@ -84,6 +85,7 @@
label: mw.msg( 'mobile-frontend-overlay-close' )
} ).toHtmlString(),
headerButtonsListClassName: '',
+ headerChrome: true,
fixedHeader: true,
spinner: icons.spinner().toHtmlString()
},
--
To view, visit https://gerrit.wikimedia.org/r/302287
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d28564541fefb18c86abc367905521940d00e5b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
