Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/302832
Change subject: Update unit tests to use non-bits favicon urls
......................................................................
Update unit tests to use non-bits favicon urls
Bug: T107430
Change-Id: Ie2001d12202353e6e9e76ddd7ab697ec801f6005
---
M tests/qunit/mmv/model/mmv.model.Repo.test.js
M tests/qunit/mmv/provider/mmv.provider.FileRepoInfo.test.js
2 files changed, 9 insertions(+), 9 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/32/302832/1
diff --git a/tests/qunit/mmv/model/mmv.model.Repo.test.js
b/tests/qunit/mmv/model/mmv.model.Repo.test.js
index 52e92be..9d371e5 100644
--- a/tests/qunit/mmv/model/mmv.model.Repo.test.js
+++ b/tests/qunit/mmv/model/mmv.model.Repo.test.js
@@ -20,7 +20,7 @@
QUnit.test( 'Repo constructor sanity check', 3, function ( assert ) {
var displayName = 'Wikimedia Commons',
- favicon = '//bits.wikimedia.org/favicon/commons.ico',
+ favicon = '//commons.wikimedia.org/favicon.ico',
apiUrl = '//commons.wikimedia.org/w/api.php',
server = '//commons.wikimedia.org',
articlePath = '//commons.wikimedia.org/wiki/$1',
@@ -38,7 +38,7 @@
QUnit.test( 'getArticlePath()', 4, function ( assert ) {
var displayName = 'Wikimedia Commons',
- favicon = '//bits.wikimedia.org/favicon/commons.ico',
+ favicon = '//commons.wikimedia.org/favicon.ico',
apiUrl = '//commons.wikimedia.org/w/api.php',
server = '//commons.wikimedia.org',
articlePath = '/wiki/$1',
@@ -70,7 +70,7 @@
QUnit.test( 'getSiteLink()', 3, function ( assert ) {
var displayName = 'Wikimedia Commons',
- favicon = '//bits.wikimedia.org/favicon/commons.ico',
+ favicon = '//commons.wikimedia.org/favicon.ico',
apiUrl = '//commons.wikimedia.org/w/api.php',
server = '//commons.wikimedia.org',
articlePath = '/wiki/$1',
diff --git a/tests/qunit/mmv/provider/mmv.provider.FileRepoInfo.test.js
b/tests/qunit/mmv/provider/mmv.provider.FileRepoInfo.test.js
index 4b0e60d..27fac6b 100644
--- a/tests/qunit/mmv/provider/mmv.provider.FileRepoInfo.test.js
+++ b/tests/qunit/mmv/provider/mmv.provider.FileRepoInfo.test.js
@@ -43,7 +43,7 @@
descBaseUrl:
'//commons.wikimedia.beta.wmflabs.org/wiki/File:',
scriptDirUrl:
'//commons.wikimedia.beta.wmflabs.org/w',
fetchDescription: true,
- favicon:
'http://bits.wikimedia.org/favicon/wikipedia.ico'
+ favicon:
'http://en.wikipedia.org.ico'
},
{
name:
'wikimediacommons',
@@ -59,7 +59,7 @@
apiurl:
'http://commons.wikimedia.org/w/api.php',
articlepath:
'/wiki/$1',
server:
'//commons.wikimedia.org',
- favicon:
'//bits.wikimedia.org/favicon/commons.ico'
+ favicon:
'//commons.wikimedia.org/favicon.ico'
},
{
name: 'local',
@@ -70,7 +70,7 @@
thumbUrl:
'//upload.beta.wmflabs.org/wikipedia/en/thumb',
initialCapital:
true,
scriptDirUrl:
'/w',
- favicon:
'http://bits.wikimedia.org/favicon/wikipedia.ico'
+ favicon:
'http://en.wikipedia.org/favicon.ico'
}
]
}
@@ -82,7 +82,7 @@
assert.strictEqual( repos.shared.displayName,
'Wikimedia Commons', 'displayName is set
correctly' );
assert.strictEqual( repos.shared.favIcon,
-
'http://bits.wikimedia.org/favicon/wikipedia.ico', 'favIcon is set correctly' );
+ 'http://en.wikipedia.org/favicon.ico', 'favIcon
is set correctly' );
assert.strictEqual( repos.shared.isLocal, false,
'isLocal is set correctly' );
assert.strictEqual( repos.shared.descBaseUrl,
'//commons.wikimedia.beta.wmflabs.org/wiki/File:', 'descBaseUrl is set
correctly' );
@@ -90,7 +90,7 @@
assert.strictEqual( repos.wikimediacommons.displayName,
'Wikimedia Commons', 'displayName is set
correctly' );
assert.strictEqual( repos.wikimediacommons.favIcon,
- '//bits.wikimedia.org/favicon/commons.ico',
'favIcon is set correctly' );
+ '//commons.wikimedia.org/favicon.ico', 'favIcon
is set correctly' );
assert.strictEqual( repos.wikimediacommons.isLocal,
false, 'isLocal is set correctly' );
assert.strictEqual( repos.wikimediacommons.apiUrl,
'http://commons.wikimedia.org/w/api.php',
'apiUrl is set correctly' );
@@ -101,7 +101,7 @@
assert.strictEqual( repos.local.displayName, null,
'displayName is set correctly' );
assert.strictEqual( repos.local.favIcon,
-
'http://bits.wikimedia.org/favicon/wikipedia.ico', 'favIcon is set correctly' );
+ 'http://en.wikipedia.org/favicon.ico', 'favIcon
is set correctly' );
assert.strictEqual( repos.local.isLocal, true, 'isLocal
is set correctly' );
} ).then( function () {
// call the data provider a second time to check caching
--
To view, visit https://gerrit.wikimedia.org/r/302832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2001d12202353e6e9e76ddd7ab697ec801f6005
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
