jenkins-bot has submitted this change and it was merged.
Change subject: When checking for valid option values include is_active in the
check.
......................................................................
When checking for valid option values include is_active in the check.
This is the more minor of the 2 approaches for T139969
- we may get feedback to go the other way
Bug: T139969
Change-Id: I97a8ca39369270bd2a31cb908d61a2c3f1347190
---
M sites/all/modules/wmf_civicrm/wmf_civicrm.module
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/sites/all/modules/wmf_civicrm/wmf_civicrm.module
b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
index f91d5f9..5c30819 100644
--- a/sites/all/modules/wmf_civicrm/wmf_civicrm.module
+++ b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
@@ -17,6 +17,7 @@
$api->OptionValue->Get(array(
'option_group_name' => $group_name,
'options' => array('limit' => 0),
+ 'is_active' => 1,
));
$cached_group[$group_name] = array();
$option_values = $api->values();
--
To view, visit https://gerrit.wikimedia.org/r/302374
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97a8ca39369270bd2a31cb908d61a2c3f1347190
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Eileen <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
