jenkins-bot has submitted this change and it was merged.
Change subject: InsertLink: Fixed IE error when selection is collapsed
......................................................................
InsertLink: Fixed IE error when selection is collapsed
In IE, when the selection was collapsed, InsertLink would produce
an error after clicking OK, sending the dialoge in an endless waiting
loop. Forcing the editor to focus first resolves the issue.
Change-Id: I68377c66844f5704a48995699de16427a773085a
---
M InsertLink/resources/bluespice.insertLink.js
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Robert Vogel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/InsertLink/resources/bluespice.insertLink.js
b/InsertLink/resources/bluespice.insertLink.js
index 349d12b..41ce6ae 100644
--- a/InsertLink/resources/bluespice.insertLink.js
+++ b/InsertLink/resources/bluespice.insertLink.js
@@ -173,6 +173,7 @@
applyData: function(window, data, plugin) {
var editor = plugin.getEditor();
editor.selection.moveToBookmark(BsInsertLinkVisualEditorConnector.bookmark);
+ editor.focus();
var node = editor.selection.getNode();
var newAnchor = null;
//Trim left and right everything (including linebreaks) that is
not a starting or ending link code
--
To view, visit https://gerrit.wikimedia.org/r/302711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68377c66844f5704a48995699de16427a773085a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Mglaser <[email protected]>
Gerrit-Reviewer: Dvogel hallowelt <[email protected]>
Gerrit-Reviewer: Ljonka <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
