Filippo Giunchedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/302917
Change subject: prometheus: remove redundant rules checking
......................................................................
prometheus: remove redundant rules checking
'promtool check-config' already checks all rules file referenced by the
configuration
Change-Id: Id6fc20c1026361d2138e82a4c0e522c8e5c4be83
---
M modules/prometheus/manifests/server.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/17/302917/1
diff --git a/modules/prometheus/manifests/server.pp
b/modules/prometheus/manifests/server.pp
index a8ab202..05e0616 100644
--- a/modules/prometheus/manifests/server.pp
+++ b/modules/prometheus/manifests/server.pp
@@ -127,7 +127,7 @@
exec { "${service_name}-reload":
command => "/bin/systemctl reload ${service_name}",
- onlyif => "/usr/bin/promtool check-config
${base_path}/prometheus.yml && /usr/bin/promtool check-rules <%=
@rule_files.join(' ') %>",
+ onlyif => "/usr/bin/promtool check-config
${base_path}/prometheus.yml",
refreshonly => true,
}
--
To view, visit https://gerrit.wikimedia.org/r/302917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6fc20c1026361d2138e82a4c0e522c8e5c4be83
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
