Filippo Giunchedi has submitted this change and it was merged.
Change subject: cassandra: don't run validate_bool on trickle_fsync
......................................................................
cassandra: don't run validate_bool on trickle_fsync
Makes puppet barf with the value from hiera:
Error: Could not retrieve catalog from remote server: Error 400 on SERVER:
"false" is not a boolean. It looks to be a String at
/etc/puppet/modules/cassandra/manifests/init.pp:330 on node
restbase1007.eqiad.wmnet
Change-Id: Idc629cce27f793cde251e08fd2c54a256b5b6f33
---
M modules/cassandra/manifests/init.pp
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Filippo Giunchedi: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/cassandra/manifests/init.pp
b/modules/cassandra/manifests/init.pp
index aeac296..846807d 100644
--- a/modules/cassandra/manifests/init.pp
+++ b/modules/cassandra/manifests/init.pp
@@ -327,7 +327,6 @@
validate_re($internode_compression, '^(all|dc|none)$')
validate_re($disk_failure_policy, '^(stop|best_effort|ignore)$')
- validate_bool($trickle_fsync)
validate_array($additional_jvm_opts)
validate_array($extra_classpath)
--
To view, visit https://gerrit.wikimedia.org/r/302948
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc629cce27f793cde251e08fd2c54a256b5b6f33
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
