jenkins-bot has submitted this change and it was merged.

Change subject: Output wgNotificationsSpecialPageLinks js var even if no local 
notifications
......................................................................


Output wgNotificationsSpecialPageLinks js var even if no local notifications

Bug: T142148
Change-Id: Id9225b9aa95a7a8ee8602282ed0d4619c7ce2bf5
---
M includes/special/SpecialNotifications.php
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/special/SpecialNotifications.php 
b/includes/special/SpecialNotifications.php
index 5447886..9a7f10a 100644
--- a/includes/special/SpecialNotifications.php
+++ b/includes/special/SpecialNotifications.php
@@ -20,6 +20,11 @@
 
                $this->addHelpLink( 'Help:Notifications/Special:Notifications' 
);
 
+               $out->addJsConfigVars( 'wgNotificationsSpecialPageLinks', array(
+                       'help' => 
'//www.mediawiki.org/wiki/Special:MyLanguage/Help:Notifications/Special:Notifications',
+                       'preferences' => SpecialPage::getTitleFor( 
'Preferences' )->getLinkURL() . '#mw-prefsection-echo',
+               ) );
+
                $user = $this->getUser();
                if ( $user->isAnon() ) {
                        // Redirect to login page and inform user of the need 
to login
@@ -151,10 +156,6 @@
 
                $out->addModules( array( 'ext.echo.special' ) );
 
-               $out->addJsConfigVars( 'wgNotificationsSpecialPageLinks', array(
-                       'help' => 
'//www.mediawiki.org/wiki/Special:MyLanguage/Help:Notifications/Special:Notifications',
-                       'preferences' => SpecialPage::getTitleFor( 
'Preferences' )->getLinkURL() . '#mw-prefsection-echo',
-               ) );
                // For no-js support
                $out->addModuleStyles( array( 'ext.echo.styles.notifications', 
'ext.echo.styles.special' ) );
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/303158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9225b9aa95a7a8ee8602282ed0d4619c7ce2bf5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to