jenkins-bot has submitted this change and it was merged. Change subject: Remove 'UnitTestList' hook ......................................................................
Remove 'UnitTestList' hook No longer needed now that extension unittests are autodiscovered. Bug: T142120 Change-Id: I05d646201297fcea4a5440eac765251ca9ac64bf --- M extension.json M src/WikibaseMediaInfoHooks.php M tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php 3 files changed, 0 insertions(+), 25 deletions(-) Approvals: Aude: Looks good to me, approved jenkins-bot: Verified diff --git a/extension.json b/extension.json index 5e2ab22..198d8d7 100644 --- a/extension.json +++ b/extension.json @@ -17,9 +17,6 @@ "WikibaseMediaInfoAlias": "WikibaseMediaInfo.i18n.alias.php" }, "Hooks": { - "UnitTestsList": [ - "Wikibase\\MediaInfo\\WikibaseMediaInfoHooks::onUnitTestsList" - ], "SetupAfterCache": [ "Wikibase\\MediaInfo\\WikibaseMediaInfoHooks::onSetupAfterCache" ], diff --git a/src/WikibaseMediaInfoHooks.php b/src/WikibaseMediaInfoHooks.php index 095c2e1..786e823 100644 --- a/src/WikibaseMediaInfoHooks.php +++ b/src/WikibaseMediaInfoHooks.php @@ -16,17 +16,6 @@ class WikibaseMediaInfoHooks { /** - * Hook to add all tests, including those that depend on MediaWiki. - * - * @see https://www.mediawiki.org/wiki/Manual:Hooks/UnitTestsList - * - * @param string[] &$paths - */ - public static function onUnitTestsList( array &$paths ) { - $paths[] = __DIR__ . '/../tests/phpunit/'; - } - - /** * Hook to register the MediaInfo entity namespaces for EntityNamespaceLookup. * * @param int[] $entityNamespacesSetting diff --git a/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php b/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php index bae53b4..c56af6c 100644 --- a/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php +++ b/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php @@ -16,17 +16,6 @@ */ class WikibaseMediaInfoHooksTest extends \PHPUnit_Framework_TestCase { - public function testOnUnitTestsList() { - $paths = []; - - Hooks::run( 'UnitTestsList', [ &$paths ] ); - - $paths = array_map( 'realpath', $paths ); - $expected = realpath( __DIR__ . '/../' ); - - $this->assertContains( $expected, $paths ); - } - public function testOnWikibaseEntityNamespaces() { global $wgNamespaceContentModels; -- To view, visit https://gerrit.wikimedia.org/r/303263 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05d646201297fcea4a5440eac765251ca9ac64bf Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/WikibaseMediaInfo Gerrit-Branch: master Gerrit-Owner: Reedy <re...@wikimedia.org> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits