jenkins-bot has submitted this change and it was merged.
Change subject: mw.UploadWizardUpload: Catch IE's "Not enough storage is
available" exceptions
......................................................................
mw.UploadWizardUpload: Catch IE's "Not enough storage is available" exceptions
Detect this failure and fall back to generating the thumbnail server-side.
Bug: T136239
Change-Id: I07a70803df6bff62bd47081b9ea910051f52afb7
---
M resources/mw.UploadWizardUpload.js
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Prtksxna: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mw.UploadWizardUpload.js
b/resources/mw.UploadWizardUpload.js
index 0cb9e59..cfdd6b4 100644
--- a/resources/mw.UploadWizardUpload.js
+++ b/resources/mw.UploadWizardUpload.js
@@ -1198,7 +1198,13 @@
image.onerror = function () {
deferred.reject();
};
- image.src = url;
+ try {
+ image.src = url;
+ } catch ( er ) {
+ // On Internet Explorer 10-11 and Edge, this
occasionally causes an exception (possibly
+ // localised) like "Not enough storage is available to
complete this operation". (T136239)
+ deferred.reject();
+ }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/303311
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07a70803df6bff62bd47081b9ea910051f52afb7
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
