Muehlenhoff has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/303548

Change subject: Support scaling of huge SVGs
......................................................................

Support scaling of huge SVGs

Passing the unlimited flag to librsvg bypasses some size limits in librsvg.
Since we have additional mitigations against huge resource consumption in
place and various legitimate SVGs which run into that limit use the
flag when shelling out to rsvg-convert.

Bug: T111815
Change-Id: I729a0eeab907220a847244d33a93f1348e92f0cf
---
M wmf-config/CommonSettings.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/48/303548/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 55638a9..2159ebb 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -534,7 +534,7 @@
 $wgSVGConverters['rsvg-broken'] = '$path/rsvg-convert -w $width -h $height -o 
$output < $input';
 if ( defined( 'HHVM_VERSION' ) ) {
        # Newer librsvg supports a sane security model by default and doesn't 
need our security patch
-       $wgSVGConverters['rsvg-secure'] = '$path/rsvg-convert -w $width -h 
$height -o $output $input';
+       $wgSVGConverters['rsvg-secure'] = '$path/rsvg-convert -u -w $width -h 
$height -o $output $input';
 } else {
        # This converter will only work when rsvg has a suitable security patch
        $wgSVGConverters['rsvg-secure'] = '$path/rsvg-convert 
--no-external-files -w $width -h $height -o $output $input';

-- 
To view, visit https://gerrit.wikimedia.org/r/303548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I729a0eeab907220a847244d33a93f1348e92f0cf
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Muehlenhoff <mmuhlenh...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to