Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/303611
Change subject: Optional limit of number of retry messages
......................................................................
Optional limit of number of retry messages
Change-Id: I9bc7e9eacc4d006b7d82aebcd535dd1e2743b939
---
M Core/DataStores/DamagedDatabase.php
M Tests/DamagedDatabaseTest.php
2 files changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig
refs/changes/11/303611/1
diff --git a/Core/DataStores/DamagedDatabase.php
b/Core/DataStores/DamagedDatabase.php
index a6e6322..3b6a92d 100644
--- a/Core/DataStores/DamagedDatabase.php
+++ b/Core/DataStores/DamagedDatabase.php
@@ -113,13 +113,18 @@
/**
* Return messages ready to be retried
*
+ * @param int $limit number of records to return
* @return array|null Records with retry_date prior to now
*/
- public function fetchRetryMessages() {
- $prepared = self::$db->prepare( '
+ public function fetchRetryMessages( $limit = 0 ) {
+ $sql = '
SELECT * FROM damaged
- WHERE retry_date < :now'
- );
+ WHERE retry_date < :now
+ ORDER BY retry_date ASC';
+ if ( $limit && is_numeric( $limit ) ) {
+ $sql .= ' LIMIT ' . $limit;
+ }
+ $prepared = self::$db->prepare( $sql );
$prepared->bindValue(
':now', UtcDate::getUtcDatabaseString(), PDO::PARAM_STR
);
diff --git a/Tests/DamagedDatabaseTest.php b/Tests/DamagedDatabaseTest.php
index 8760fbb..0569276 100644
--- a/Tests/DamagedDatabaseTest.php
+++ b/Tests/DamagedDatabaseTest.php
@@ -34,7 +34,7 @@
}
protected static function getTestMessage( $uniq = null ) {
- if ( !$uniq ) {
+ if ( !$uniq ) {
$uniq = mt_rand();
}
return array(
--
To view, visit https://gerrit.wikimedia.org/r/303611
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bc7e9eacc4d006b7d82aebcd535dd1e2743b939
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
