Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/303996
Change subject: Fix-ups to inline documentation ...................................................................... Fix-ups to inline documentation Change-Id: I9c74e54dbb3e500957a18558a8b90156ffe181c4 --- M robots.txt M wikibase/queryService/api/Sparql.js M wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js M wikibase/queryService/ui/toolbar/ActionBar.js M wikibase/queryService/ui/visualEditor/SelectorBox.js M wikibase/queryService/ui/visualEditor/SparqlQuery.js M wikibase/queryService/ui/visualEditor/VisualEditor.js 7 files changed, 13 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui refs/changes/96/303996/1 diff --git a/robots.txt b/robots.txt index 0af05cf..a49145d 100644 --- a/robots.txt +++ b/robots.txt @@ -1,4 +1,4 @@ -# robots.txt for http:/query.wikidata.org/ +# robots.txt for http://query.wikidata.org/ User-agent: * Disallow: /sparql Disallow: /bigdata diff --git a/wikibase/queryService/api/Sparql.js b/wikibase/queryService/api/Sparql.js index a88ee10..40b939c 100644 --- a/wikibase/queryService/api/Sparql.js +++ b/wikibase/queryService/api/Sparql.js @@ -17,7 +17,7 @@ * @author Jonas Kress * @constructor * - * @param {string} serviceUri (optional) serviceUri URI to the SPARQL service endpoint + * @param {string} [serviceUri] Optional URI to the SPARQL service endpoint */ function SELF( serviceUri ) { diff --git a/wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js b/wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js index fe3cccd..eef9df0 100644 --- a/wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js +++ b/wikibase/queryService/ui/resultBrowser/helper/FormatterHelper.js @@ -223,7 +223,7 @@ * Creates a thumbnail URL from given commons resource URL * * @param {string} url - * @param {number} width + * @param {number} [width] * @return {String} */ SELF.prototype.getCommonsResourceFileNameThumbnail = function( url, width ) { diff --git a/wikibase/queryService/ui/toolbar/ActionBar.js b/wikibase/queryService/ui/toolbar/ActionBar.js index f8115db..603551c 100644 --- a/wikibase/queryService/ui/toolbar/ActionBar.js +++ b/wikibase/queryService/ui/toolbar/ActionBar.js @@ -55,6 +55,9 @@ }; /** + * @param {string} text + * @param {string} type + * @param {int} progress * @private */ SELF.prototype._getProgressbar = function( text, type, progress ) { @@ -64,9 +67,11 @@ }; /** + * @param {string} text + * @param {string} type * @private */ - SELF.prototype._getBar = function( text, type, isProgress ) { + SELF.prototype._getBar = function( text, type ) { return $( '<div class="label label-' + type + '"/>' ).text( text ); }; diff --git a/wikibase/queryService/ui/visualEditor/SelectorBox.js b/wikibase/queryService/ui/visualEditor/SelectorBox.js index 7de9433..3af306a 100644 --- a/wikibase/queryService/ui/visualEditor/SelectorBox.js +++ b/wikibase/queryService/ui/visualEditor/SelectorBox.js @@ -14,7 +14,7 @@ * * @author Jonas Kress * @constructor - * @param {wikibase.queryService.api.Wikibase} api + * @param {wikibase.queryService.api.Wikibase} [api] */ function SELF( api ) { diff --git a/wikibase/queryService/ui/visualEditor/SparqlQuery.js b/wikibase/queryService/ui/visualEditor/SparqlQuery.js index 2c9fb19..3f8de44 100644 --- a/wikibase/queryService/ui/visualEditor/SparqlQuery.js +++ b/wikibase/queryService/ui/visualEditor/SparqlQuery.js @@ -73,7 +73,7 @@ /** * Set LIMIT * - * @param {string} limit + * @param {int} limit */ SELF.prototype.setLimit = function( limit ) { if ( !limit ) { diff --git a/wikibase/queryService/ui/visualEditor/VisualEditor.js b/wikibase/queryService/ui/visualEditor/VisualEditor.js index 507e016..f5d8628 100644 --- a/wikibase/queryService/ui/visualEditor/VisualEditor.js +++ b/wikibase/queryService/ui/visualEditor/VisualEditor.js @@ -23,8 +23,8 @@ * * @author Jonas Kress * @constructor - * @param {wikibase.queryService.api.Wikibase} api - * @param {wikibase.queryService.ui.visualEditor.SelectorBox} selectorBox + * @param {wikibase.queryService.api.Wikibase} [api] + * @param {wikibase.queryService.ui.visualEditor.SelectorBox} [selectorBox] */ function SELF( api, selectorBox ) { this._api = api; -- To view, visit https://gerrit.wikimedia.org/r/303996 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9c74e54dbb3e500957a18558a8b90156ffe181c4 Gerrit-PatchSet: 1 Gerrit-Project: wikidata/query/gui Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
