jenkins-bot has submitted this change and it was merged.
Change subject: Rewrite wikitext parsing regular expressions in QuerySamples
......................................................................
Rewrite wikitext parsing regular expressions in QuerySamples
Change-Id: Iae2acb10db4dae088b5adeac536a7cc0e486e411
---
M wikibase/queryService/api/QuerySamples.js
1 file changed, 9 insertions(+), 12 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikibase/queryService/api/QuerySamples.js
b/wikibase/queryService/api/QuerySamples.js
index db8f0fb..8214688 100644
--- a/wikibase/queryService/api/QuerySamples.js
+++ b/wikibase/queryService/api/QuerySamples.js
@@ -38,13 +38,10 @@
},
dataType: 'jsonp'
} )
- .done(
- function ( data ) {
- var wikitext =
data.query.pages[Object.keys( data.query.pages )].revisions[0]['*'];
- wikitext = wikitext.replace(
/\{\{!\}\}/g, '|' );
-
- deferred.resolve( self._extract(
wikitext ) );
- } );
+ .done( function ( data ) {
+ var wikitext = data.query.pages[Object.keys(
data.query.pages )].revisions[0]['*'];
+ deferred.resolve( self._extract( wikitext ) );
+ } );
return deferred;
};
@@ -77,10 +74,10 @@
* @private
*/
SELF.prototype._extractExamples = function ( section, sectionHeader ) {
- var regexParagraph =
/(?:[\=]+)([^\=]*)(?:[\=]+)\n(?:[]*?)(?:[^=]*?)({{SPARQL\s*\|[\s\S]*?}}\n){1}/g,
- regexQuery = /query\s*\=([^]+)(?:}}|\|)/,
- regexExtraPrefix = /extraprefix\s*\=([^]+?)(?:\||}})+/,
- regexTags = /{{Q\|([^]+?)\|([^]+?)}}+/g,
+ var regexParagraph =
/^=+([^=]+)=+\n[^=]*?(\{\{SPARQL\s*\|[\s\S]*?\}\})/gm,
+ regexQuery = /\|\s*query\s*=([^|]*?)(?:\||\}\})/,
+ regexExtraPrefix =
/\|\s*extraprefix\s*=([^|]*?)(?:\||\}\})/,
+ regexTags = /\{\{Q\|([^{|}]+)\|([^{|}]+)\}\}/gi,
m,
examples = [];
@@ -88,7 +85,7 @@
var paragraph = m[0], title = m[1].trim(), tags = [],
tag,
href = PAGE_URL + '#' + encodeURIComponent(
title.replace( / /g, '_' ) ).replace( /%/g, '.' ),
sparqlTemplate = m[2],
- query = sparqlTemplate.match( regexQuery
)[1].trim();
+ query = sparqlTemplate.match( regexQuery
)[1].replace( /\{\{!\}\}/g, '|' ).trim();
if ( sparqlTemplate.match( regexExtraPrefix ) ) {
query = sparqlTemplate.match( regexExtraPrefix
)[1] + '\n\n' + query;
--
To view, visit https://gerrit.wikimedia.org/r/304006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae2acb10db4dae088b5adeac536a7cc0e486e411
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
