BryanDavis has uploaded a new change for review. https://gerrit.wikimedia.org/r/304249
Change subject: Change check_message_ok test text ...................................................................... Change check_message_ok test text Use the check_message_ok test text to describe the rules enforced and link to the wiki documentation. Change-Id: I6a8b937949442a9be4c99ef3c2eac52159f64fbe --- M commit_message_validator/tests/data/check_message_ok.msg 1 file changed, 32 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/integration/commit-message-validator refs/changes/49/304249/1 diff --git a/commit_message_validator/tests/data/check_message_ok.msg b/commit_message_validator/tests/data/check_message_ok.msg index 018adc6..a7fb18a 100644 --- a/commit_message_validator/tests/data/check_message_ok.msg +++ b/commit_message_validator/tests/data/check_message_ok.msg @@ -1,8 +1,35 @@ -Add mediawiki::iwlink define and use it with role::mobilefrontend +This is the subject line of the commit -Add a new Puppet define that can be used to easily add rows to the -interwiki links table. The define is used to add a few interwiki -language links to mobilewiki provisioned by role:mobilefrontend. +The body of the commit message starts after a blank line. It contains just +about any random text, but each line should not exceed 100 characters. Really +there is no good reason for any body line to exceed 72 characters (80 column +display with an 8 character tab leading the line) except in the case of a long +URL that is embedded in the message. -Bug: T106633 +Other checks: +- First line <=80 characters +- Second line blank +- No line >100 characters +- "Bug:" is capitalized +- "Bug:" is followed by a space +- Exactly one task id on each Bug: line +- "Depends-On:" is capitalized +- "Depends-On:" is followed by a space +- Exactly one change id on each Depends-On: line +- No "Task: ", "Fixes: ", "Closes: " lines +- For any "^Bug: " line, next line is not blank +- For any "^Bug: " line, prior line is another Bug: line or empty +- For any "^Depends-On: " line, next line is not blank +- For any "^Depends-On: " line, prior line is Bug|Depends-On or empty +- Exactly one "Change-Id: " line per commit +- For "Change-Id: " line, prior line is empty or "^(Bug|Depends-On): " +- No blank lines between any "(Bug|Depends-On): " lines and "Change-Id: " +- Only "(cherry picked from commit" can follow "Change-Id: " +- Message has at least 3 lines (subject, blank, Change-Id) + +https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines + +Bug: T109119 +Depends-On: I2deb4cd50d50a87a34b0bf4277ad55f77e75dd0d Change-Id: Ifcd397165df1cbf9fa04f2044e1bb33ad7414d8d +(cherry picked from commit a24ca11e277afd8b5259d44b2d645d4dbb99502f) -- To view, visit https://gerrit.wikimedia.org/r/304249 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6a8b937949442a9be4c99ef3c2eac52159f64fbe Gerrit-PatchSet: 1 Gerrit-Project: integration/commit-message-validator Gerrit-Branch: master Gerrit-Owner: BryanDavis <bda...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
