jenkins-bot has submitted this change and it was merged. Change subject: AuthManager: Always whitelist some special pages ......................................................................
AuthManager: Always whitelist some special pages Special:UserLogout should be whitelisted, if Special:UserLogin is whitelisted, as otherwise the user is able to login, but not able to logout anymore (given, that the sys-admin hasn't change the $wgWhitelistRead config variable). Special:ChangePassword redirects to Special:ChangeCredentials. Instead of adding this special page, it should be done explicitly in the wiki configuration (LocalSettings.php). For this reason, the whitelist is removed, too. Change-Id: I271efb517bf0ec0022e6fe29673570ca08e8fe1a --- M includes/Title.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gergő Tisza: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/Title.php b/includes/Title.php index ea42768..ed445cc 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -2319,8 +2319,8 @@ # If the user is allowed to read pages, he is allowed to read all pages $whitelisted = true; } elseif ( $this->isSpecial( 'Userlogin' ) - || $this->isSpecial( 'ChangePassword' ) || $this->isSpecial( 'PasswordReset' ) + || $this->isSpecial( 'Userlogout' ) ) { # Always grant access to the login page. # Even anons need to be able to log in. -- To view, visit https://gerrit.wikimedia.org/r/303437 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I271efb517bf0ec0022e6fe29673570ca08e8fe1a Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits