jenkins-bot has submitted this change and it was merged.
Change subject: QuerySamples parser: remove meaningless repetitions
......................................................................
QuerySamples parser: remove meaningless repetitions
An "exactly 1" reprtition does not do anything. One match is always
done.
An "one or more" reprtition at the end of the pattern does not make
a difference. One match is always done. The regex can succeed then.
There is no need to look for "possibly more" when what we have is
already anough.
Change-Id: I2a68b0370a50ddec189eafd67ade55d8037cd45d
---
M wikibase/queryService/api/QuerySamples.js
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Smalyshev: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikibase/queryService/api/QuerySamples.js
b/wikibase/queryService/api/QuerySamples.js
index 9394857..1c8cfd2 100644
--- a/wikibase/queryService/api/QuerySamples.js
+++ b/wikibase/queryService/api/QuerySamples.js
@@ -76,10 +76,10 @@
* @private
*/
SELF.prototype._extractExamples = function ( section, sectionHeader ) {
- var regexParagraph =
/(?:=+)([^=]*)(?:=+)\n(?:[]*?)(?:[^=]*?)(\{\{SPARQL\s*\|[\s\S]*?}}\n){1}/g,
+ var regexParagraph =
/(?:=+)([^=]*)(?:=+)\n(?:[]*?)(?:[^=]*?)(\{\{SPARQL\s*\|[\s\S]*?}}\n)/g,
regexQuery = /query\s*=([^]+)(?:}}|\|)/,
- regexExtraPrefix = /extraprefix\s*=([^]+?)(?:\||}})+/,
- regexTags = /\{\{Q\|([^]+?)\|([^]+?)}}+/g,
+ regexExtraPrefix = /extraprefix\s*=([^]+?)(?:\||}})/,
+ regexTags = /\{\{Q\|([^]+?)\|([^]+?)}}/g,
m,
examples = [];
--
To view, visit https://gerrit.wikimedia.org/r/304218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a68b0370a50ddec189eafd67ade55d8037cd45d
Gerrit-PatchSet: 2
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
