Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/304829
Change subject: Type hint array for HTMLFormFieldCloner::getInputHTMLForKey() ...................................................................... Type hint array for HTMLFormFieldCloner::getInputHTMLForKey() I was a bit fast with merging I18edfcb62f7b21f2c1990c73944ee6a956fd4901, because I think, type hinting the type of the parameter would make sense, too. Bug: T142912 Change-Id: Id397847c6c078047f3daa84db68ccf3e629ca531 --- M includes/htmlform/fields/HTMLFormFieldCloner.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/29/304829/1 diff --git a/includes/htmlform/fields/HTMLFormFieldCloner.php b/includes/htmlform/fields/HTMLFormFieldCloner.php index f39f54b..5d8f491 100644 --- a/includes/htmlform/fields/HTMLFormFieldCloner.php +++ b/includes/htmlform/fields/HTMLFormFieldCloner.php @@ -257,7 +257,7 @@ * @param array $values * @return string */ - protected function getInputHTMLForKey( $key, $values ) { + protected function getInputHTMLForKey( $key, array $values ) { $displayFormat = isset( $this->mParams['format'] ) ? $this->mParams['format'] : $this->mParent->getDisplayFormat(); -- To view, visit https://gerrit.wikimedia.org/r/304829 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id397847c6c078047f3daa84db68ccf3e629ca531 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits