jenkins-bot has submitted this change and it was merged.
Change subject: GallerySlideshow: getImageInfo: Reject promise if there is no
thumbnail
......................................................................
GallerySlideshow: getImageInfo: Reject promise if there is no thumbnail
Bug: T142799
Change-Id: Iacca208fa39afd1e330db1d1fa9f3bfbc6b76b81
---
M resources/src/mediawiki/page/gallery-slideshow.js
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
MarkTraceur: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki/page/gallery-slideshow.js
b/resources/src/mediawiki/page/gallery-slideshow.js
index 85ded44..3b2c86e 100644
--- a/resources/src/mediawiki/page/gallery-slideshow.js
+++ b/resources/src/mediawiki/page/gallery-slideshow.js
@@ -325,6 +325,11 @@
var api, title, params,
imageSrc = $img.attr( 'src' );
+ // Reject promise if there is no thumbnail image
+ if ( $img[ 0 ] === undefined ) {
+ return $.Deferred().reject();
+ }
+
if ( this.imageInfoCache[ imageSrc ] === undefined ) {
api = new mw.Api();
// TODO: This supports only gallery of images
--
To view, visit https://gerrit.wikimedia.org/r/304971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacca208fa39afd1e330db1d1fa9f3bfbc6b76b81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
