jenkins-bot has submitted this change and it was merged.
Change subject: Toggle all checkboxes an changing visibilit of 'All layers'
......................................................................
Toggle all checkboxes an changing visibilit of 'All layers'
Change-Id: Ia660b26aacb24c2bcdfd04412ae58702ac241717
---
M wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
1 file changed, 28 insertions(+), 4 deletions(-)
Approvals:
Smalyshev: Looks good to me, approved
Lucas Werkmeister: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
b/wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
index cbdb7a5..89cacbb 100644
--- a/wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
+++ b/wikibase/queryService/ui/resultBrowser/CoordinateResultBrowser.js
@@ -68,20 +68,44 @@
} ).fitBounds( markerGroups[ LAYER_DEFAULT_GROUP ].getBounds()
);
this._setTileLayer( map );
+ this._createControls( map, markerGroups );
- //map controls
+ $element.html( container );
+ };
+
+ /**
+ * Create map controls
+ *
+ * @private
+ */
+ SELF.prototype._createControls = function( map, markerGroups ) {
+ //zoom control
map.addControl( L.control.zoomBox( {
modal: false,
className: 'glyphicon glyphicon-zoom-in'
} ) );
map.addControl( new ScrollToTopButton() );
+ //layers control
var numberOfLayers = Object.keys( markerGroups ).length;
if ( numberOfLayers > 1 ) {
- this._getLayerControl( markerGroups ).addTo( map );
- }
+ var control = this._getLayerControl( markerGroups
).addTo( map );
- $element.html( container );
+ // update layer control
+ map.on( 'overlayadd overlayremove', function ( event ) {
+ if ( event.layer !== markerGroups[
LAYER_DEFAULT_GROUP ] ) {
+ return;
+ }
+ $.each( markerGroups, function( i, layer ) {
+ if ( event.type === 'overlayadd' ) {
+ map.addLayer( layer );
+ } else {
+ map.removeLayer( layer );
+ }
+ } );
+ control._update();
+ } );
+ }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/305216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia660b26aacb24c2bcdfd04412ae58702ac241717
Gerrit-PatchSet: 2
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Lucas Werkmeister <m...@lucaswerkmeister.de>
Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
