Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306459
Change subject: WIP Fix failing Selenium tests
......................................................................
WIP Fix failing Selenium tests
Bug: T139613
Change-Id: I3d327b3cfd5f52e60fee07095eefdd8feecaba98
---
M modules/ve-mw/tests/browser/features/support/env.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
2 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/59/306459/1
diff --git a/modules/ve-mw/tests/browser/features/support/env.rb
b/modules/ve-mw/tests/browser/features/support/env.rb
index 5a104d1..c1072b2 100644
--- a/modules/ve-mw/tests/browser/features/support/env.rb
+++ b/modules/ve-mw/tests/browser/features/support/env.rb
@@ -1,8 +1,3 @@
require 'mediawiki_selenium/cucumber'
require 'mediawiki_selenium/pages'
require 'mediawiki_selenium/step_definitions'
-
-require_relative 'hooks'
-require_relative 'visual_editor_helper'
-
-World(VisualEditorHelper)
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 23a0ee7..7e0b4cc 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -4,18 +4,6 @@
page_url 'User:<%= env.user %>/<%= env.browser_name
%>?vehidebetadialog=true&veaction=edit'
- def self.translate(string)
- language = ENV['LANGUAGE_SCREENSHOT_CODE']
-
- file_name = File.expand_path("../../../i18n/#{language}.json", __dir__)
- unless File.exist?(file_name)
- file_name = File.expand_path('../../../i18n/en.json', __dir__)
- end
-
- json = JSON.parse(File.read(file_name))
- json[string] || ''
- end
-
div(:add_a_template_title, class: 'oo-ui-processDialog-location', text: /Add
a template/)
text_field(:add_category, css: 'div.ve-ui-mwCategoryInputWidget > input')
span(:add_template, text: 'Add template')
@@ -161,7 +149,6 @@
div(:top_editing_tabs, id: 'p-views')
li(:ve_edit_tab, id: 'ca-ve-edit')
li(:edit_source_tab, id: 'ca-edit')
- a(:save_page, text: translate('visualeditor-savedialog-label-save'))
div(:save_enabled, css: 'div.ve-init-mw-desktopArticleTarget-toolbar
.oo-ui-toolbar-actions >
div.oo-ui-flaggedElement-progressive.oo-ui-widget-enabled')
div(:search_page_link, class: 'oo-ui-optionWidget-selected')
a(:second_reference, text: '[1]', index: 2)
--
To view, visit https://gerrit.wikimedia.org/r/306459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d327b3cfd5f52e60fee07095eefdd8feecaba98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
