jenkins-bot has submitted this change and it was merged.
Change subject: Media viewer design tweaks
......................................................................
Media viewer design tweaks
Hide close and slider buttons on click and resposition close icon
Bug: T107607
Change-Id: Ie54ca76b74ba2cc46edf107797ae6dff491924c2
---
M resources/mobile.mediaViewer/ImageOverlay.js
M resources/mobile.mediaViewer/mediaViewer.less
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.mediaViewer/ImageOverlay.js
b/resources/mobile.mediaViewer/ImageOverlay.js
index 4d9f805..604c0bc 100644
--- a/resources/mobile.mediaViewer/ImageOverlay.js
+++ b/resources/mobile.mediaViewer/ImageOverlay.js
@@ -182,6 +182,7 @@
* Event handler that toggles the details bar.
*/
onToggleDetails: function () {
+ this.$( '.cancel, .slider-button' ).toggle();
this.$details.toggle();
this._positionImage();
},
diff --git a/resources/mobile.mediaViewer/mediaViewer.less
b/resources/mobile.mediaViewer/mediaViewer.less
index fae095b..6b33af6 100644
--- a/resources/mobile.mediaViewer/mediaViewer.less
+++ b/resources/mobile.mediaViewer/mediaViewer.less
@@ -43,7 +43,7 @@
// FIXME: change styling after overlay overhaul
.cancel {
position: absolute;
- right: 10px;
+ right: 0;
top: 10px;
}
--
To view, visit https://gerrit.wikimedia.org/r/306801
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie54ca76b74ba2cc46edf107797ae6dff491924c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
