Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/306945
Change subject: Revert "Copy style attribute to lazy placeholder"
......................................................................
Revert "Copy style attribute to lazy placeholder"
This caused several more issues with Math equations and reflow
issues.
This reverts commit 302ae2de1f011633af243e4519bdf40034f9c8b7.
Change-Id: I38f14d72ecfd2a15da8286884530e06888d1993a
---
M includes/MobileFormatter.php
M resources/mobile.startup/Skin.js
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/45/306945/1
diff --git a/includes/MobileFormatter.php b/includes/MobileFormatter.php
index 8244529..67d0cc9 100644
--- a/includes/MobileFormatter.php
+++ b/includes/MobileFormatter.php
@@ -266,7 +266,7 @@
$imgPlaceholder = $doc->createElement( 'span' );
$imgPlaceholder->setAttribute( 'class',
'lazy-image-placeholder' );
$imgPlaceholder->setAttribute( 'style',
$dimensionsStyle );
- foreach ( [ 'src', 'alt', 'width', 'height', 'srcset',
'class', 'style' ] as $attr ) {
+ foreach ( [ 'src', 'alt', 'width', 'height', 'srcset',
'class' ] as $attr ) {
if ( $img->hasAttribute( $attr ) ) {
$imgPlaceholder->setAttribute(
"data-$attr", $img->getAttribute( $attr ) );
}
diff --git a/resources/mobile.startup/Skin.js b/resources/mobile.startup/Skin.js
index 1472068..49da904 100644
--- a/resources/mobile.startup/Skin.js
+++ b/resources/mobile.startup/Skin.js
@@ -275,7 +275,6 @@
height: height,
src: $placeholder.attr( 'data-src' ),
alt: $placeholder.attr( 'data-alt' ),
- style: $placeholder.attr( 'data-style' ),
srcset: $placeholder.attr( 'data-srcset' )
} );
},
--
To view, visit https://gerrit.wikimedia.org/r/306945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38f14d72ecfd2a15da8286884530e06888d1993a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
