Mobrovac has uploaded a new change for review. https://gerrit.wikimedia.org/r/307641
Change subject: Revert "Revert "Change-Prop: Rerender summary on wikidata item update"" ...................................................................... Revert "Revert "Change-Prop: Rerender summary on wikidata item update"" This reverts commit edc9e0b0d1507deb4c1a2c7f8e77297d77f1e495. Change Iaded5c5f6b03ee7b5e37712bd753bb93db900657 introduced re-rendering the summary of pages that use wikidata descriptions, but after its merge all of the edits coming from wikidata.org were being rejected by Change Prop, so we reverted it. However, it turns out that the rule is correct; there was a bug in the way the service handled the response from wikidata. This has been fixed in https://github.com/wikimedia/change-propagation/pull/88 and is live in production, so it is safe to re-enable the rule. Change-Id: Ib77f28f3aa84ff86f2b1e01c93bba40d60701cf6 --- M modules/changeprop/templates/config.yaml.erb 1 file changed, 36 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/41/307641/1 diff --git a/modules/changeprop/templates/config.yaml.erb b/modules/changeprop/templates/config.yaml.erb index 9792086..fdcccec 100644 --- a/modules/changeprop/templates/config.yaml.erb +++ b/modules/changeprop/templates/config.yaml.erb @@ -16,17 +16,17 @@ options: host: <%= @purge_host %> port: <%= @purge_port %> -# /{api:sys}/links: -# x-modules: -# - path: src/sys/dep_updates.js -# options: -# templates: -# mw_api: -# uri: <%= @mwapi_uri %> -# headers: -# host: '{{message.meta.domain}}' -# body: -# formatversion: 2 + /{api:sys}/links: + x-modules: + - path: src/sys/dep_updates.js + options: + templates: + mw_api: + uri: <%= @mwapi_uri %> + headers: + host: '{{message.meta.domain}}' + body: + formatversion: 2 /{api:sys}/queue: x-modules: - path: src/sys/kafka.js @@ -440,3 +440,28 @@ models: 'reverted|damaging|goodfaith' revids: '{{message.rev_id}}' precache: true + + # Re-renders summary on WikiData item update + wikidata_description: + topic: mediawiki.revision_create + match: + meta: + domain: www.wikidata.org + exec: + method: 'post' + uri: '/sys/links/wikidata_descriptions' + body: '{{globals.message}}' + + on_wikidata_description_change: + topic: resource_change + match: + meta: + uri: '/https?:\/\/[^\/]+\/wiki\/(?<title>.+)/' + tags: [ 'change-prop', 'wikidata' ] + exec: + method: get + uri: '<%= @restbase_uri %>/{{message.meta.domain}}/v1/page/summary/{{match.meta.uri.title}}' + headers: + cache-control: no-cache + query: + redirect: false \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/307641 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib77f28f3aa84ff86f2b1e01c93bba40d60701cf6 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Mobrovac <mobro...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
