Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307971
Change subject: Ensure lazy image placeholders without height can be loaded
......................................................................
Ensure lazy image placeholders without height can be loaded
Bug: T143768
Change-Id: Ic396eacad0ab10e2e82f87369a1ef3dc2a8bd17c
(cherry picked from commit e67b7ed6273faa104a390690d3ad24110220442c)
---
M resources/mobile.startup/Skin.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/71/307971/1
diff --git a/resources/mobile.startup/Skin.js b/resources/mobile.startup/Skin.js
index 49da904..783c8ae 100644
--- a/resources/mobile.startup/Skin.js
+++ b/resources/mobile.startup/Skin.js
@@ -221,7 +221,9 @@
if (
mw.viewport.isElementCloseToViewport( placeholder, offset ) &&
- $placeholder.is( ':visible' )
+ // If a placeholder is an
inline element without a height attribute set it will record as hidden
+ // to circumvent this we also
need to test the height (see T143768).
+ ( $placeholder.is( ':visible' )
|| $placeholder.height() === 0 )
) {
self.loadImage( $placeholder );
return false;
--
To view, visit https://gerrit.wikimedia.org/r/307971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic396eacad0ab10e2e82f87369a1ef3dc2a8bd17c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.28.0-wmf.17
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
