jenkins-bot has submitted this change and it was merged.
Change subject: Log tested URL for all tests
......................................................................
Log tested URL for all tests
Lets log the tested URL together with the result URL so you easy can
find specific tests in the log.
Also log the tested URL when we get an error from WebPagTest so
it's easier to see what URL are failing.
Bug: T144505
Change-Id: I564d3e55c1e19330dce2b61c0bab97ee0e0453af
---
M lib/index.js
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/index.js b/lib/index.js
index 6dd0ef6..549c42a 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -70,8 +70,10 @@
// make sure we catch that
https://phabricator.wikimedia.org/T127833
return bluebird.reject('We got an empty result object from
WebPageTest');
}
- console.log('WebPageTest run: ' + data.data.summary +
'&medianRun=' +
- argv.medianrun + '&medianMetric=' + wptOptions.median);
+ console.log('Tested URL ' + data.data.url + ' for ' +
data.data.location +
+ ' with connectivity ' + data.data.connectivity + ' result: ' +
+ data.data.summary + '&medianRun=' + argv.medianrun +
+ '&medianMetric=' + wptOptions.median);
if (argv.verbose) {
console.log(JSON.stringify(data, null, 1));
@@ -97,7 +99,8 @@
if (data.data.median && data.data.median.firstView &&
data.data.median.firstView.result > 399) {
return bluebird.reject('We got error code ' +
- data.data.median.firstView.result + ' for ' +
data.data.summary);
+ data.data.median.firstView.result + ' for URL ' +
data.data.url +
+ ' result ' + data.data.summary);
}
return;
});
--
To view, visit https://gerrit.wikimedia.org/r/307993
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I564d3e55c1e19330dce2b61c0bab97ee0e0453af
Gerrit-PatchSet: 2
Gerrit-Project: performance/WebPageTest
Gerrit-Branch: master
Gerrit-Owner: Phedenskog <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
