Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/308229

Change subject: Flow mentions: Don't allow invalid users (IPs are invalid)
......................................................................

Flow mentions: Don't allow invalid users (IPs are invalid)

Bug: T144613
Change-Id: I9ba6a1815031ec7f891288ad7d38d22ff21900eb
---
M 
modules/editor/editors/visualeditor/ui/widgets/mw.flow.ve.ui.MentionTargetInputWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/29/308229/1

diff --git 
a/modules/editor/editors/visualeditor/ui/widgets/mw.flow.ve.ui.MentionTargetInputWidget.js
 
b/modules/editor/editors/visualeditor/ui/widgets/mw.flow.ve.ui.MentionTargetInputWidget.js
index d33ee29..bf622fa 100644
--- 
a/modules/editor/editors/visualeditor/ui/widgets/mw.flow.ve.ui.MentionTargetInputWidget.js
+++ 
b/modules/editor/editors/visualeditor/ui/widgets/mw.flow.ve.ui.MentionTargetInputWidget.js
@@ -63,7 +63,7 @@
                // Then check the user exists
                return mw.flow.ve.userCache.get( this.value ).then(
                        function ( user ) {
-                               return !user.missing;
+                               return !user.missing && !user.invalid;
                        },
                        function () {
                                // If the API is down or behaving strangely, we 
shouldn't prevent

-- 
To view, visit https://gerrit.wikimedia.org/r/308229
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ba6a1815031ec7f891288ad7d38d22ff21900eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to