jenkins-bot has submitted this change and it was merged.
Change subject: filecache: Remove unused ObjectFileCache class
......................................................................
filecache: Remove unused ObjectFileCache class
This was originally intended for use by ResourceLoader but it was
incomplete and not actually used by ResourceLoader at first.
Then 93d358cd added support for FileCache to ResourceLoader with
a separate ResourceFileCache class.
Also fixed typo in HTMLFileCache from 6559b8bf.
ObjectFileCache is not mentioned anywhere else in Wikimedia Git.
Change-Id: I69cca27ee7cd922da12f1793660432709c273be6
---
M autoload.php
M includes/cache/HTMLFileCache.php
D includes/cache/ObjectFileCache.php
3 files changed, 3 insertions(+), 56 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/autoload.php b/autoload.php
index 0c63ba5..71f1809 100644
--- a/autoload.php
+++ b/autoload.php
@@ -981,7 +981,6 @@
'ORAResult' => __DIR__ . '/includes/db/DatabaseOracle.php',
'ObjectCache' => __DIR__ . '/includes/objectcache/ObjectCache.php',
'ObjectFactory' => __DIR__ . '/includes/libs/ObjectFactory.php',
- 'ObjectFileCache' => __DIR__ . '/includes/cache/ObjectFileCache.php',
'OldChangesList' => __DIR__ . '/includes/changes/OldChangesList.php',
'OldLocalFile' => __DIR__ . '/includes/filerepo/file/OldLocalFile.php',
'OracleInstaller' => __DIR__ .
'/includes/installer/OracleInstaller.php',
diff --git a/includes/cache/HTMLFileCache.php b/includes/cache/HTMLFileCache.php
index ea2e20b..1bab0f5 100644
--- a/includes/cache/HTMLFileCache.php
+++ b/includes/cache/HTMLFileCache.php
@@ -30,13 +30,13 @@
*/
class HTMLFileCache extends FileCacheBase {
/**
- * Construct an ObjectFileCache from a Title and an action
+ * Construct an HTMLFileCache object from a Title and an action
+ *
+ * @deprecated since 1.24, instantiate this class directly
* @param Title|string $title Title object or prefixed DB key string
* @param string $action
* @throws MWException
* @return HTMLFileCache
- *
- * @deprecated Since 1.24, instantiate this class directly
*/
public static function newFromTitle( $title, $action ) {
return new self( $title, $action );
diff --git a/includes/cache/ObjectFileCache.php
b/includes/cache/ObjectFileCache.php
deleted file mode 100644
index c7ef044..0000000
--- a/includes/cache/ObjectFileCache.php
+++ /dev/null
@@ -1,52 +0,0 @@
-<?php
-/**
- * Object cache in the file system.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
- * @file
- * @ingroup Cache
- */
-
-/**
- * Object cache in the file system.
- *
- * @ingroup Cache
- */
-class ObjectFileCache extends FileCacheBase {
- /**
- * Construct an ObjectFileCache from a key and a type
- * @param string $key
- * @param string $type
- * @return ObjectFileCache
- */
- public static function newFromKey( $key, $type ) {
- $cache = new self();
-
- $cache->mKey = (string)$key;
- $cache->mType = (string)$type;
-
- return $cache;
- }
-
- /**
- * Get the base file cache directory
- * @return string
- */
- protected function cacheDirectory() {
- return $this->baseCacheDirectory() . '/object';
- }
-}
--
To view, visit https://gerrit.wikimedia.org/r/308911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69cca27ee7cd922da12f1793660432709c273be6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
