Divec has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/308919

Change subject: Fix 'new ve.dm.Transaction.newFromDocumentInsertion' typo
......................................................................

Fix 'new ve.dm.Transaction.newFromDocumentInsertion' typo

Seems to originate in Iaddc4a7e7cc42a468a62ae550637f3eaacb64e07 . It was 
harmless because
the function returned an object which supplants the spurious one 'new' creates.

Change-Id: I40b39815f0b39e1a57a2d32f58f8a1a0b454cbcb
---
M src/dm/ve.dm.SurfaceFragment.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/19/308919/1

diff --git a/src/dm/ve.dm.SurfaceFragment.js b/src/dm/ve.dm.SurfaceFragment.js
index 837ddd1..f56087f 100644
--- a/src/dm/ve.dm.SurfaceFragment.js
+++ b/src/dm/ve.dm.SurfaceFragment.js
@@ -841,7 +841,7 @@
                        .getAnnotationsFromOffset( offset === 0 ? 0 : offset - 
1 );
        }
 
-       tx = new ve.dm.Transaction.newFromDocumentInsertion( doc, offset, 
newDoc, newDocRange );
+       tx = ve.dm.Transaction.newFromDocumentInsertion( doc, offset, newDoc, 
newDocRange );
        if ( !tx.isNoOp() ) {
                // Set the range to cover the inserted content; the offset 
translation will be wrong
                // if newFromInsertion() decided to move the insertion point

-- 
To view, visit https://gerrit.wikimedia.org/r/308919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I40b39815f0b39e1a57a2d32f58f8a1a0b454cbcb
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <da...@troi.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to