Giuseppe Lavagetto has submitted this change and it was merged.
Change subject: Change-Prop: Fix concurrency calculation for transcludes
......................................................................
Change-Prop: Fix concurrency calculation for transcludes
364a635 doubled the concurrency for transclusion updates. However, it
seems that Puppet interprets that as a string, causing Ruby to repeat
the number twice instead of doubling it numerically. This patch fixes
that by forcing a conversion to a number before the multiplication.
Change-Id: I8af871cfd15accaa2337716d4960dec497c607b2
---
M modules/changeprop/templates/config.yaml.erb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mobrovac: Looks good to me, but someone else must approve
Giuseppe Lavagetto: Verified; Looks good to me, approved
diff --git a/modules/changeprop/templates/config.yaml.erb
b/modules/changeprop/templates/config.yaml.erb
index 8d5476b..6904feb 100644
--- a/modules/changeprop/templates/config.yaml.erb
+++ b/modules/changeprop/templates/config.yaml.erb
@@ -220,7 +220,7 @@
body: '{{globals.message}}'
on_transclusion_update:
- concurrency: <%= (@concurrency * 2).to_i %>
+ concurrency: <%= @concurrency.to_i * 2 %>
topic: resource_change
match:
meta:
--
To view, visit https://gerrit.wikimedia.org/r/308957
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8af871cfd15accaa2337716d4960dec497c607b2
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
