jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Turn on CirrusSearch bm25 A/B test"
......................................................................
Revert "Turn on CirrusSearch bm25 A/B test"
This reverts commit 49d069769dbd9ac2a459a5bafc9dffdea5bf3cf9.
Bug: T143588
Change-Id: Ic527cb67fae7bf6695f0c1a0c26282e8c53a4cfa
(cherry picked from commit bdb89182defcef826217ca08f3d703409f089fad)
---
M modules/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 3 insertions(+), 19 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.wikimediaEvents.searchSatisfaction.js
b/modules/ext.wikimediaEvents.searchSatisfaction.js
index 3217a9b..12777e2 100644
--- a/modules/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/ext.wikimediaEvents.searchSatisfaction.js
@@ -100,8 +100,7 @@
function initialize( session ) {
var sessionId = session.get( 'sessionId' ),
- haveSubTest = mw.config.get( 'wgDBname' ) ===
'enwiki',
- sampleSize = haveSubTest ? 66 : 200,
+ sampleSize = 200,
/**
* Determines whether the user is part of the
population size.
*
@@ -150,16 +149,6 @@
// have a search session id, generate one.
if ( !session.set( 'sessionId', randomToken() )
) {
return;
- }
-
- if ( haveSubTest && !oneIn( 3 ) ) {
- session.set( 'subTest', chooseBucket( [
- 'bm25:control',
- 'bm25:allfield',
- 'bm25:inclinks',
- 'bm25:inclinks_pv',
- 'bm25:inclinks_pv_rev'
- ] ) );
}
}
@@ -580,13 +569,8 @@
// text setup, so wrap in atMostOnce to ensure it's
// only run once.
initSubTest = atMostOnce( function ( session ) {
- if ( session.get( 'subTest' ) ) {
- $( '<input>' ).attr( {
- type: 'hidden',
- name: 'cirrusUserTesting',
- value: session.get( 'subTest' )
- } ).prependTo( $( 'input[type=search]' ).closest(
'form' ) );
- }
+ // jshint unused:false
+ // no sub test currently running
} );
/**
--
To view, visit https://gerrit.wikimedia.org/r/309188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic527cb67fae7bf6695f0c1a0c26282e8c53a4cfa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.28.0-wmf.17
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
