Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/309819
Change subject: Use extension data instead of (un)serialize hack in properties
......................................................................
Use extension data instead of (un)serialize hack in properties
ParserOutput::setExtensionData() is intended to store structured data
for extensions and since it doesn't automatically get stuck in a
database, we don't need the unserialize/serialize hack that abusing page
properties required.
Change-Id: Ic814cbd4045cee9c8ec2b5cdf9309f7ec7dc079e
---
M MassMessage.hooks.php
M includes/MassMessageTargets.php
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage
refs/changes/19/309819/1
diff --git a/MassMessage.hooks.php b/MassMessage.hooks.php
index ba5bb41..a61cd01 100644
--- a/MassMessage.hooks.php
+++ b/MassMessage.hooks.php
@@ -59,12 +59,12 @@
return ''; // Output doesn't matter
}
$output = $parser->getOutput();
- $current = $output->getProperty( 'massmessage-targets' );
+ $current = $output->getExtensionData( 'massmessage-targets' );
if ( !$current ) {
- $output->setProperty( 'massmessage-targets', serialize(
[ $data ] ) );
+ $output->setExtensionData( 'massmessage-targets', [
$data ] );
} else {
- $output->setProperty( 'massmessage-targets', serialize(
- array_merge( unserialize( $current ), [ $data
] ) ) );
+ $output->setExtensionData( 'massmessage-targets',
+ array_merge( $current, [ $data ] ) );
}
return '';
}
diff --git a/includes/MassMessageTargets.php b/includes/MassMessageTargets.php
index 8504ffd..a0c7c95 100644
--- a/includes/MassMessageTargets.php
+++ b/includes/MassMessageTargets.php
@@ -158,7 +158,7 @@
// Parse
$output = $parser->parse( $text, $spamlist, $parserOptions );
- $data = unserialize( $output->getProperty(
'massmessage-targets' ) );
+ $data = $output->getExtensionData( 'massmessage-targets' );
if ( $data ) {
return $data;
--
To view, visit https://gerrit.wikimedia.org/r/309819
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic814cbd4045cee9c8ec2b5cdf9309f7ec7dc079e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
