jenkins-bot has submitted this change and it was merged.
Change subject: Change scroll threshold to viewport height * 1.5
......................................................................
Change scroll threshold to viewport height * 1.5
The threshold used to test whether related articles need to be
loaded has been changed to the viewport height * 1.5 from the more
complicated formula used earlier.
The change should help with loading related articles more smoothly.
To eliminate the lag completely the related articles need to be
rendered in the back-end.
Bug: T144822
Change-Id: I9d189163b95533ca43fa3d8632f65b280470f12a
---
M resources/ext.relatedArticles.readMore.bootstrap/index.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.relatedArticles.readMore.bootstrap/index.js
b/resources/ext.relatedArticles.readMore.bootstrap/index.js
index a70c3fd..e906776 100644
--- a/resources/ext.relatedArticles.readMore.bootstrap/index.js
+++ b/resources/ext.relatedArticles.readMore.bootstrap/index.js
@@ -22,7 +22,7 @@
*/
function loadRelatedArticles() {
var readMore = $( '.read-more-container' ).get( 0 ),
- scrollThreshold = $( document ).height() / 2 -
$window.height();
+ scrollThreshold = $window.height() * 1.5;
if ( mw.viewport.isElementCloseToViewport( readMore,
scrollThreshold ) ) {
$.when(
--
To view, visit https://gerrit.wikimedia.org/r/310050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d189163b95533ca43fa3d8632f65b280470f12a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/RelatedArticles
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
