Alexandros Kosiaris has submitted this change and it was merged.
Change subject: Remove defaults from puppetmaster::passenger
......................................................................
Remove defaults from puppetmaster::passenger
There is only one call to this class in the entire tree and it already
specifies all of the parameters anyway. Plus, this is an implementation
class, it should be not called directly anyway.
Change-Id: Ide83cc690ae2364a5eb1e6f4e2109f47d5343dec
---
M modules/puppetmaster/manifests/passenger.pp
D modules/puppetmaster/tests/passenger.pp
2 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
Alexandros Kosiaris: Verified; Looks good to me, approved
diff --git a/modules/puppetmaster/manifests/passenger.pp
b/modules/puppetmaster/manifests/passenger.pp
index 4781d3e..f527cbc 100644
--- a/modules/puppetmaster/manifests/passenger.pp
+++ b/modules/puppetmaster/manifests/passenger.pp
@@ -14,10 +14,10 @@
# Adds a Deny from statement (order Allow,Deny), limiting access
# to the passenger service.
class puppetmaster::passenger(
- $bind_address = '*',
- $verify_client = 'optional',
- $allow_from = [],
- $deny_from = []
+ $bind_address,
+ $verify_client,
+ $allow_from,
+ $deny_from,
) {
include ::apache::mod::passenger
diff --git a/modules/puppetmaster/tests/passenger.pp
b/modules/puppetmaster/tests/passenger.pp
deleted file mode 100644
index 3aec31e..0000000
--- a/modules/puppetmaster/tests/passenger.pp
+++ /dev/null
@@ -1 +0,0 @@
-include puppetmaster::passenger
--
To view, visit https://gerrit.wikimedia.org/r/214628
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide83cc690ae2364a5eb1e6f4e2109f47d5343dec
Gerrit-PatchSet: 5
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
