jenkins-bot has submitted this change and it was merged. Change subject: Use correct protocol for feed requests ......................................................................
Use correct protocol for feed requests Change-Id: Ia6afa83e4e103eb26687ba5f8087cb6e61608add --- M app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: jenkins-bot: Verified Niedzielski: Looks good to me, approved diff --git a/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java b/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java index a99cc40..db0a504 100644 --- a/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java +++ b/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java @@ -37,9 +37,9 @@ public void request(@NonNull Context context, @NonNull Site site, int age, @NonNull Callback cb) { cancel(); UtcDate date = DateUtil.getUtcRequestDateFor(age); - // TODO: Use app retrofit, etc., when feed endpoints are deployed to production - Retrofit retrofit = RetrofitFactory.newInstance(site, - String.format(Locale.ROOT, Prefs.getRestbaseUriFormat(), "http", site.authority())); + String endpoint = String.format(Locale.ROOT, Prefs.getRestbaseUriFormat(), site.scheme(), + site.authority()); + Retrofit retrofit = RetrofitFactory.newInstance(site, endpoint); AggregatedFeedContentClient.Service service = retrofit.create(Service.class); call = service.get(date.year(), date.month(), date.date()); call.enqueue(new CallbackAdapter(cb, site, age)); -- To view, visit https://gerrit.wikimedia.org/r/310607 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6afa83e4e103eb26687ba5f8087cb6e61608add Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits