jenkins-bot has submitted this change and it was merged. Change subject: Don't be fooled by CVV="0" ......................................................................
Don't be fooled by CVV="0" Bug: T145846 Change-Id: I96292dd7369b0c0fb88777c18cdd9618ec8fd02a --- M globalcollect_gateway/globalcollect.adapter.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ejegg: Looks good to me, approved jenkins-bot: Verified diff --git a/globalcollect_gateway/globalcollect.adapter.php b/globalcollect_gateway/globalcollect.adapter.php index 6d389c5..abc5d9d 100644 --- a/globalcollect_gateway/globalcollect.adapter.php +++ b/globalcollect_gateway/globalcollect.adapter.php @@ -652,7 +652,7 @@ $status_result = $this->do_transaction( 'GET_ORDERSTATUS' ); $validationAction = $this->getValidationAction(); $cvv_result = $this->getData_Unstaged_Escaped( 'cvv_result' ); - $gotCVV = !empty( $cvv_result ); + $gotCVV = strlen( $cvv_result ) > 0; // TODO: This logging is redundant with the response from GET_ORDERSTATUS. $logmsg = 'CVV Result: ' . $this->getData_Unstaged_Escaped( 'cvv_result' ); $logmsg .= ', AVS Result: ' . $this->getData_Unstaged_Escaped( 'avs_result' ); -- To view, visit https://gerrit.wikimedia.org/r/311098 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96292dd7369b0c0fb88777c18cdd9618ec8fd02a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Awight <awi...@wikimedia.org> Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com> Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org> Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org> Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org> Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits