Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311208

Change subject: Avoid using bogus empty database names in queries
......................................................................

Avoid using bogus empty database names in queries

Fixes regression from 32c7a9bf46b8ba8d81

Change-Id: I029ad785afd6a2ba4589a24a813d4b348b708112
---
M includes/db/Database.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/08/311208/1

diff --git a/includes/db/Database.php b/includes/db/Database.php
index 3d9b41a..b4a39f9 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -1924,7 +1924,7 @@
                }
 
                # Quote $database and merge it with the table name if needed
-               if ( $database !== null ) {
+               if ( strlen( $database ) ) {
                        if ( $format == 'quoted' && !$this->isQuotedIdentifier( 
$database ) ) {
                                $database = $this->addIdentifierQuotes( 
$database );
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/311208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I029ad785afd6a2ba4589a24a813d4b348b708112
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to