Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311625
Change subject: push to origin in make-release
......................................................................
push to origin in make-release
Bug: T141314
Change-Id: I064bff17d83de7c6ffee04d9484dc74ecbcbad04
---
M scripts/make-release.py
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/25/311625/1
diff --git a/scripts/make-release.py b/scripts/make-release.py
index 485dcf3..39ccb55 100755
--- a/scripts/make-release.py
+++ b/scripts/make-release.py
@@ -9,7 +9,7 @@
Step 2: (e.g., --beta --push):
- Creates an annotated tag called 'releases/versionName'
- - Pushes the git tag to gerrit for history
+ - Pushes the git tag to origin for history
- TODO (Not implemented yet): Uploads certain bits to
releases.mediawiki.org: releasesprod, beta
To run
@@ -66,13 +66,13 @@
sh.git.tag('-a', get_git_tag_name(target, version_name), '-m', target)
-def push_to_gerrit(target, version_name):
+def git_push_tag(target, version_name):
"""
- Pushes the git tag to gerrit
+ Pushes the git tag to origin
"""
tag_name = get_git_tag_name(target, version_name)
print('pushing tag ' + tag_name)
- sh.git.push('gerrit', tag_name)
+ sh.git.push('origin', tag_name)
def make_release(flavors, custom_channel):
@@ -172,7 +172,7 @@
help='Step 1: Custom versionName&channel. OEMs w/ Play')
group.add_argument('--app',
help='Step 1: Custom versionName&channel. OEMs wout/
Play.')
- parser.add_argument('--push', help='Step 2: create&push git tag to gerrit
remote.',
+ parser.add_argument('--push', help='Step 2: create&push git tag to
origin.',
action='store_true')
args = parser.parse_args()
custom_channel = 'ignore'
@@ -206,7 +206,7 @@
version_name = get_version_name_from_apk(apk_file)
for target in targets:
git_tag(target, version_name)
- push_to_gerrit(target, version_name)
+ git_push_tag(target, version_name)
else:
make_release(flavors, custom_channel)
copy_artifacts(flavors[0])
--
To view, visit https://gerrit.wikimedia.org/r/311625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I064bff17d83de7c6ffee04d9484dc74ecbcbad04
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
