[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Clean up === false comparisons

[Catrope (Code Review)]

Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311651

Change subject: Clean up === false comparisons
......................................................................

Clean up === false comparisons

Change-Id: Ib56fba798e6ebeba4879201890c038251089e32f
---
M includes/Hooks.php
1 file changed, 12 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES 
refs/changes/51/311651/1

diff --git a/includes/Hooks.php b/includes/Hooks.php
index 5729887..fee726d 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -83,7 +83,7 @@
         * @return bool
         */
        public static function onChangesListSpecialPageFilters( 
ChangesListSpecialPage $clsp, &$filters ) {
-               if ( self::oresEnabled( $clsp->getUser() ) === false ) {
+               if ( !self::oresEnabled( $clsp->getUser() ) ) {
                        return true;
                }
 
@@ -125,7 +125,7 @@
                array &$query_options, array &$join_conds, FormOptions $opts
        ) {
                global $wgUser;
-               if ( self::oresEnabled( $wgUser ) === false ) {
+               if ( !self::oresEnabled( $wgUser ) ) {
                        return true;
                }
 
@@ -181,7 +181,7 @@
        public static function onEnhancedChangesListModifyLineData( 
EnhancedChangesList $ecl, array &$data,
                array $block, RCCacheEntry $rcObj, array &$classes
        ) {
-               if ( self::oresEnabled( $ecl->getUser() ) === false ) {
+               if ( !self::oresEnabled( $ecl->getUser() ) ) {
                        return true;
                }
 
@@ -201,7 +201,7 @@
        public static function onEnhancedChangesListModifyBlockLineData( 
EnhancedChangesList $ecl,
                array &$data, RCCacheEntry $rcObj
        ) {
-               if ( self::oresEnabled( $ecl->getUser() ) === false ) {
+               if ( !self::oresEnabled( $ecl->getUser() ) ) {
                        return true;
                }
 
@@ -224,7 +224,7 @@
        public static function onOldChangesListRecentChangesLine( ChangesList 
&$changesList, &$s,
                $rc, &$classes = []
        ) {
-               if ( self::oresEnabled( $changesList->getUser() ) === false ) {
+               if ( !self::oresEnabled( $changesList->getUser() ) ) {
                        return true;
                }
 
@@ -250,7 +250,7 @@
         * @param array $query
         */
        public static function onContribsGetQueryInfo( ContribsPager $pager, 
&$query ) {
-               if ( self::oresEnabled( $pager->getUser() ) === false ) {
+               if ( !self::oresEnabled( $pager->getUser() ) ) {
                        return true;
                }
 
@@ -292,7 +292,7 @@
        public static function onSpecialContributionsFormatRowFlags(
                RequestContext $context, $row, array &$flags
        ) {
-               if ( self::oresEnabled( $context->getUser() ) === false ) {
+               if ( !self::oresEnabled( $context->getUser() ) ) {
                        return true;
                }
 
@@ -310,7 +310,7 @@
        public static function onContributionsLineEnding(
                ContribsPager $pager, &$ret, $row, array &$classes
        ) {
-               if ( self::oresEnabled( $pager->getUser() ) === false ) {
+               if ( !self::oresEnabled( $pager->getUser() ) ) {
                        return true;
                }
 
@@ -331,7 +331,7 @@
        public static function onSpecialContributionsGetFormFilters(
                SpecialContributions $page, array &$filters
        ) {
-               if ( self::oresEnabled( $page->getUser() ) === false ) {
+               if ( !self::oresEnabled( $page->getUser() ) ) {
                        return true;
                }
 
@@ -402,7 +402,7 @@
        public static function onGetPreferences( $user, &$preferences ) {
                global $wgOresDamagingThresholds;
 
-               if ( self::oresEnabled( $user ) === false ) {
+               if ( !self::oresEnabled( $user ) ) {
                        return true;
                }
 
@@ -440,7 +440,7 @@
         * Add CSS styles to output page
         */
        public static function onBeforePageDisplay( OutputPage &$out, Skin 
&$skin ) {
-               if ( self::oresEnabled( $out->getUser() ) === false ) {
+               if ( !self::oresEnabled( $out->getUser() ) ) {
                        return true;
                }
                $out->addModuleStyles( 'ext.ores.styles' );
@@ -472,10 +472,7 @@
         * @return bool
         */
        private static function oresEnabled( User $user ) {
-               if ( BetaFeatures::isFeatureEnabled( $user, 'ores-enabled' ) ) {
-                       return true;
-               }
-               return false;
+               return BetaFeatures::isFeatureEnabled( $user, 'ores-enabled' );
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/311651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib56fba798e6ebeba4879201890c038251089e32f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits