Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311672
Change subject: Move entity usage from basic to properties section in
action=info
......................................................................
Move entity usage from basic to properties section in action=info
Change-Id: I28f0b0cf1bc0fd01ec938bd81db926148618ed3e
(cherry picked from commit 10b578df03c03da951e0e75e1298a78f5221c938)
---
M client/includes/Hooks/InfoActionHookHandler.php
M client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/72/311672/1
diff --git a/client/includes/Hooks/InfoActionHookHandler.php
b/client/includes/Hooks/InfoActionHookHandler.php
index d5880ad..db662aa 100644
--- a/client/includes/Hooks/InfoActionHookHandler.php
+++ b/client/includes/Hooks/InfoActionHookHandler.php
@@ -70,7 +70,7 @@
}
if ( $usage ) {
- $pageInfo['header-basic'][] = $this->formatEntityUsage(
$context, $usage );
+ $pageInfo['header-properties'][] =
$this->formatEntityUsage( $context, $usage );
}
return $pageInfo;
diff --git a/client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php
b/client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php
index b5728fb..a8f0cee 100644
--- a/client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php
+++ b/client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php
@@ -47,6 +47,8 @@
$context->msg(
'wikibase-pageinfo-entity-id' )->escaped(),
'https://www.wikidata.org/wiki/Q4'
),
+ ),
+ 'header-properties' => array(
array(
$context->msg(
'wikibase-pageinfo-entity-usage' )->escaped(),
"<ul><li>https://www.wikidata.org/wiki/Q4</li><ul><li>Sitelink</li></ul></ul>",
@@ -58,7 +60,7 @@
);
$cases[] = array(
- array( 'header-basic' => array(
+ array( 'header-properties' => array(
array(
$context->msg(
'wikibase-pageinfo-entity-usage' )->escaped(),
"<ul><li>https://www.wikidata.org/wiki/Q4</li><ul><li>Sitelink</li></ul></ul>",
@@ -66,7 +68,7 @@
)
),
$context,
- array( 'header-basic' => array() ),
+ array( 'header-properties' => array() ),
false,
new ItemId( 'Q4' ),
'namespace does not have wikibase enabled'
--
To view, visit https://gerrit.wikimedia.org/r/311672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28f0b0cf1bc0fd01ec938bd81db926148618ed3e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.28.0-wmf.19
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
