Matmarex has uploaded a new change for review. Change subject: (bug 44385) make ext.vector.collapsibleTabs actually work ......................................................................
(bug 44385) make ext.vector.collapsibleTabs actually work It didn't hide empty dropdown since the headings having been changed from h5 to h3 some time ago. I guess nobody noticed because this would only ever be visible to non-autoconfirmed users who don't have the right to move pages (as it's the only situation where the dropdown could contain exactly one item, the history link). Additionally, it was using different element dimensions than the skin itself, causing the dropdown to be slightly borked, and different animation durations for hiding and showing. Nobody noticed since it didn't work at all, as explained above. Also applied some generic cleanup and code conventions. Change-Id: Ib4ffef1b8868cbad3d4597a95c9468565c0c8849 --- M modules/ext.vector.collapsibleTabs.js 1 file changed, 20 insertions(+), 15 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Vector refs/changes/17/47717/1 -- To view, visit https://gerrit.wikimedia.org/r/47717 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4ffef1b8868cbad3d4597a95c9468565c0c8849 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Vector Gerrit-Branch: master Gerrit-Owner: Matmarex <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
