Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/312427
Change subject: Hygiene: Only allow calls to closePopup on an active link ...................................................................... Hygiene: Only allow calls to closePopup on an active link Change-Id: I7c15870e1586aa8629af723accad67dee5483369 --- M resources/ext.popups.renderer/desktopRenderer.js 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/27/312427/1 diff --git a/resources/ext.popups.renderer/desktopRenderer.js b/resources/ext.popups.renderer/desktopRenderer.js index b5ae9f6..6def177 100644 --- a/resources/ext.popups.renderer/desktopRenderer.js +++ b/resources/ext.popups.renderer/desktopRenderer.js @@ -259,10 +259,6 @@ var fadeInClass, fadeOutClass, $activeLink = getActiveLink(); - if ( !$activeLink ) { - return false; - } - $activeLink.off( 'mouseleave blur', mw.popups.render.leaveActive ); fadeInClass = ( mw.popups.$popup.hasClass( 'mwe-popups-fade-in-up' ) ) ? @@ -331,7 +327,8 @@ * @method closeOnEsc */ mw.popups.render.closeOnEsc = function ( event ) { - if ( event.keyCode === 27 ) { + var $activeLink = getActiveLink(); + if ( event.keyCode === 27 && $activeLink ) { mw.popups.render.closePopup(); } }; @@ -345,7 +342,10 @@ */ mw.popups.render.leaveActive = function () { closeTimer = mw.popups.render.wait( mw.popups.render.POPUP_CLOSE_DELAY ).done( function () { - mw.popups.render.closePopup(); + var $activeLink = getActiveLink(); + if ( $activeLink ) { + mw.popups.render.closePopup(); + } } ); }; -- To view, visit https://gerrit.wikimedia.org/r/312427 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7c15870e1586aa8629af723accad67dee5483369 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits