DCausse has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312501
Change subject: Fix cindy failures
......................................................................
Fix cindy failures
Increased min word length for morelike querie to 2 to avoid matching
pages on the word "1" and make sure that ChangeMe is on the first
page.
Switched to "page" from [ "page" ] for Database::select I think it's
an annotation problem on Database or pahn that is not able to infer
param types from interface.
Change-Id: Ifde771eb17ebeb7470964db617514b6cac1c89a1
---
M includes/Sanity/Checker.php
M tests/browser/features/more_like_this_options.feature
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch
refs/changes/01/312501/1
diff --git a/includes/Sanity/Checker.php b/includes/Sanity/Checker.php
index ae44be2..51a3a5c 100644
--- a/includes/Sanity/Checker.php
+++ b/includes/Sanity/Checker.php
@@ -294,7 +294,7 @@
$dbr = wfGetDB( DB_REPLICA );
$where = 'page_id IN (' . $dbr->makeList( $pageIds ) . ')';
$res = $dbr->select(
- [ 'page' ],
+ 'page',
WikiPage::selectFields(),
$where,
__METHOD__
diff --git a/tests/browser/features/more_like_this_options.feature
b/tests/browser/features/more_like_this_options.feature
index ba0a180..f41ab68 100644
--- a/tests/browser/features/more_like_this_options.feature
+++ b/tests/browser/features/more_like_this_options.feature
@@ -29,7 +29,7 @@
Then there are no search results
Scenario: Searching for morelike:<page> with the title field and settings
with poor precision
- When I set More Like This Options to title field, word length to 1 and I
search for morelike:More Like Me 1
+ When I set More Like This Options to title field, word length to 2 and I
search for morelike:More Like Me 1
Then ChangeMe is in the search results
Scenario: Searching for morelike:<page> with the all field works even if
cirrusMtlUseFields is set to yes
--
To view, visit https://gerrit.wikimedia.org/r/312501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifde771eb17ebeb7470964db617514b6cac1c89a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: DCausse <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
