Cenarium has uploaded a new change for review.
https://gerrit.wikimedia.org/r/312647
Change subject: Pass new stable revision to review log for dis-approvals
......................................................................
Pass new stable revision to review log for dis-approvals
Currently, the old stable revision is passed to the review log when a
revision is unreviewed, same as when a revision is reviewed. But then
the changes that were unreviewed are never shown in the log, since the
old stable revision is the same as the unreviewed revision, or more recent.
Instead it should be the new stable revision that gets pased. This way,
the log will show which changes were unreviewed. The fix doesn't work for
old revisions that get unreviewed, but in that case it would be a pain to
know which prior revision to base the diff on.
Change-Id: Ib3d709679396ace8b794648c827685b209a7e5f7
---
M business/RevisionReviewForm.php
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/47/312647/1
diff --git a/business/RevisionReviewForm.php b/business/RevisionReviewForm.php
index 69e7a49..1992955 100644
--- a/business/RevisionReviewForm.php
+++ b/business/RevisionReviewForm.php
@@ -496,13 +496,14 @@
# Delete from flaggedrevs table
$frev->delete();
- # Update the article review log
- $oldSvId = $oldSv ? $oldSv->getRevId() : 0;
- FlaggedRevsLog::updateReviewLog( $this->page, $this->dims,
$this->oldFlags,
- $this->comment, $this->oldid, $oldSvId, false );
-
# Get the new stable version as of now
$sv = FlaggedRevision::determineStable( $this->page, FR_MASTER
/*consistent*/ );
+
+ # Update the article review log
+ $svId = $sv ? $sv->getRevId() : 0;
+ FlaggedRevsLog::updateReviewLog( $this->page, $this->dims,
$this->oldFlags,
+ $this->comment, $this->oldid, $svId, false );
+
# Update recent changes
self::updateRecentChanges( $frev->getRevision(), 'unpatrol',
$sv );
# Update page and tracking tables and clear cache
--
To view, visit https://gerrit.wikimedia.org/r/312647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3d709679396ace8b794648c827685b209a7e5f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Cenarium <cenarium.sy...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
